Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating upgrade guide #5001

Merged
merged 18 commits into from
Feb 28, 2024
Merged

Updating upgrade guide #5001

merged 18 commits into from
Feb 28, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Feb 27, 2024 •
edited by runleonarun
Loading

Closes #4998

What are you changing in this pull request and why?

Updating the 1.8 migration guide with:

  • Unit tests
  • New installation workflow
  • Global config quick hits

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner February 27, 2024 23:45
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Feb 27, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 3:25pm

@matthewshaver
Merge branch 'mirgration-1-8' into add_unit_testing_to_upgrade_guide
2df4703
@matthewshaver
add unit testing callout to upgrade guide (#4997)
54373fc 
## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If related to an open 
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

Part 1 of #4998

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/vercel.json`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Feb 27, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Feb 27, 2024
@matthewshaver
Update 01-upgrading-to-v1.8.md
b80b828 
Adding indirect selection
runleonarun
runleonarun reviewed Feb 28, 2024
View reviewed changes
website/docs/docs/dbt-versions/core-upgrade/01-upgrading-to-v1.8.md Outdated

Before v1.8, when you installed an adapter, you would automatically get `dbt-core ` installed along with the adapter package (if you didn’t already have an existing, compatible version of dbt-core).

Beginning in v1.8, you must install _both_ dbt-core and the desired adapter. A new `pip` installation needs to look like this:
Copy link
Collaborator

@runleonarun runleonarun Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver In the issue, Grace suggested adding a link tot he migration guide:

link to the migration guide for adapter maintainers: dbt-labs/dbt-adapters#87

mirnawong1
mirnawong1 requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great and some awesome info there! some small suggestions and link fix!

matthewshaver and others added 6 commits February 28, 2024 10:03
@matthewshaver @mirnawong1
Update website/docs/docs/dbt-versions/core-upgrade/01-upgrading-to-v1…
1411cc2 
….8.md

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver @mirnawong1
Update website/docs/docs/dbt-versions/core-upgrade/01-upgrading-to-v1…
7a294cc 
….8.md

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver @mirnawong1
Update website/docs/docs/dbt-versions/core-upgrade/01-upgrading-to-v1…
eb125e4 
….8.md

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver @mirnawong1
Update website/docs/docs/dbt-versions/core-upgrade/01-upgrading-to-v1…
5f2176a 
….8.md

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver @mirnawong1
Update website/docs/docs/dbt-versions/core-upgrade/01-upgrading-to-v1…
008ee5e 
….8.md

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@matthewshaver @mirnawong1
Apply suggestions from code review
e500315 
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Feb 28, 2024
mirnawong1
mirnawong1 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, love the linking to the github discussion for the adapters change!

@matthewshaver matthewshaver merged commit 5e76830 into current Feb 28, 2024
7 checks passed
@matthewshaver matthewshaver deleted the mirgration-1-8 branch February 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun left review comments

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete the upgrade guide for 1.8 beta
4 participants
@matthewshaver @runleonarun @mirnawong1 @graciegoheen