Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data_tests callout #5017

Merged
merged 14 commits into from
Mar 14, 2024
Merged

Data_tests callout #5017

merged 14 commits into from
Mar 14, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Added a callout warning users on 1.8 to update their configuration

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner February 28, 2024 21:28
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 7:34pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Feb 28, 2024
@matthewshaver matthewshaver linked an issue Feb 28, 2024 that may be closed by this pull request
Add data_test #4989
Closed
1 task
nghi-ly
nghi-ly reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left one idea about the new section, lemme know what you think

website/docs/docs/build/data-tests.md Outdated Show resolved Hide resolved
website/docs/docs/build/data-tests.md Show resolved Hide resolved
nghi-ly
nghi-ly reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one follow-up question

website/docs/docs/build/data-tests.md Show resolved Hide resolved
website/docs/docs/build/data-tests.md Outdated Show resolved Hide resolved
graciegoheen
graciegoheen reviewed Mar 1, 2024
View reviewed changes
website/docs/docs/build/data-tests.md Outdated

models:

name: orders
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the yml spacing looks a bit weird here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-29 at 7 08 53 PM

@graciegoheen
Copy link
Collaborator

Thoughts on adding the same callout to the reference page https://docs-getdbt-com-git-tests-data-dbt-labs.vercel.app/reference/data-test-configs

matthewshaver and others added 2 commits February 29, 2024 19:10
@matthewshaver
Update data-tests.md
4c0d4df
@matthewshaver @graciegoheen
Update website/docs/docs/build/data-tests.md
178b870 
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
graciegoheen
graciegoheen reviewed Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one open question of if we also want to add this callout to the reference page for data tests

@matthewshaver matthewshaver merged commit 9dd7a81 into current Mar 14, 2024
7 checks passed
@matthewshaver matthewshaver deleted the tests-data branch March 14, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen left review comments

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data_test
3 participants
@matthewshaver @graciegoheen @nghi-ly