Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle v keyword argument for model versions #5051

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Mar 8, 2024

What are you changing in this pull request and why?

See dbt-labs/dbt-core#9742 for the motivating use-case.

Checklist

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 11:31pm

@dbeatty10 dbeatty10 marked this pull request as ready for review March 8, 2024 23:26
@dbeatty10 dbeatty10 requested a review from a team as a code owner March 8, 2024 23:26
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Mar 8, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thank you @dbeatty10 !

@mirnawong1 mirnawong1 merged commit 0f36232 into current Mar 9, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/versioning-keyword-arguments branch March 9, 2024 00:25
mirnawong1 added a commit that referenced this pull request Mar 11, 2024
## What are you changing in this pull request and why?

While working on #5051,
I saw some other opportunities for improvement and split them into their
own stand-alone PR.

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants