Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-generic-tests.md #5055

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Update custom-generic-tests.md #5055

merged 3 commits into from
Mar 11, 2024

Conversation

ialdg
Copy link
Contributor

@ialdg ialdg commented Mar 9, 2024

I introduced a place holder text for you to replace with the actual URL link to the proper Github website since the present link doesn't work. Regards.
IL.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

I introduced a place holder text for you to replace with the actual URL link to the proper Github website since the present link doesn't work.
Regards.
IL.
@ialdg ialdg requested a review from a team as a code owner March 9, 2024 13:55
Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 10:56am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed content Improvements or additions to content labels Mar 9, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ialdg , thanks for opening this pr up and great catch ! I've made a tweak to it so the link reference is avoided for now. thanks again and looking forward to future contributions ✨

@mirnawong1 mirnawong1 merged commit ef0fc40 into dbt-labs:current Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants