Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add move to cloud guide part 1 #5058

Merged
merged 88 commits into from
Mar 14, 2024
Merged

add move to cloud guide part 1 #5058

merged 88 commits into from
Mar 14, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Mar 11, 2024

this pr adds a new guide helping users understand the considerations needed when they move from core to cloud.

it lays out what requirements are needed, any differences, and more.

this guide will follow up with two more guides pending review.

Resolves #5068

@mirnawong1 mirnawong1 requested a review from a team as a code owner March 11, 2024 16:40
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:40pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person and removed Docs team Authored by the Docs team @dbt Labs labels Mar 11, 2024
@@ -0,0 +1,58 @@
import React, { useRef, useEffect } from 'react';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is def no needed but i added a confetti effect as a surprise easter egg at the end of the guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's no objections, i'm happy to request a frontend task and ask the front end team to review this part of the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Mar 11, 2024
@mirnawong1
Copy link
Contributor Author

hey @JKarlavige , thanks for your review! i’ve folded in your feedback - can you rereview

@mirnawong1
Copy link
Contributor Author

hey @matthewshaver , thanks so much for your feedback! can you rereview?

- [Import a Git repository](/docs/cloud/git/import-a-project-by-git-url) from any valid Git URL that points to a dbt project.

### Additional configuration
- Log into dbt Cloud using [OAuth connections](/docs/cloud/git/connect-github) to integrate with your source code platform. It automatically links to the repository using one of the native integrations set at the account level. <Lifecycle status='enterprise' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a bullet point? It's under a different header and it doesn't line up with the bullets under #2 if it's supposed to be a part of that I think we should remove the header and line it up, otherwise we can probably remove the bullet and make it a paragraph

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an optional config so it is a step for those that are enterprise. that's why i initially had it as a numbered bullet. i think removing the header hides it a little and i'd like to make this optional config more visible. maybe i can combine both and number it as a 1:

Additional configuration

  1. Log into dbt Cloud using OAuth connections to integrate with your source code platform. It automatically links to the repository using one of the native integrations set at the account level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me!

Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Verified confetti component still works after the updates 🚢🚢🚢

@mirnawong1
Copy link
Contributor Author

merging this now

@mirnawong1 mirnawong1 merged commit 18caf8b into current Mar 14, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the add-core-to-cloud-guide branch March 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asana task: Add a confetti component to specifc guides
4 participants