-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add move to cloud guide part 1 #5058
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,58 @@ | |||
import React, { useRef, useEffect } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is def no needed but i added a confetti effect as a surprise easter egg at the end of the guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there's no objections, i'm happy to request a frontend task and ask the front end team to review this part of the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's a loom showing how it works: https://www.loom.com/share/d9dbde480bfe4ee089f132a43889ea5f?sid=2ead730d-32c4-45bc-aeca-024e96aa4240
…/docs.getdbt.com into add-core-to-cloud-guide
…/docs.getdbt.com into add-core-to-cloud-guide
hey @JKarlavige , thanks for your review! i’ve folded in your feedback - can you rereview |
hey @matthewshaver , thanks so much for your feedback! can you rereview? |
- [Import a Git repository](/docs/cloud/git/import-a-project-by-git-url) from any valid Git URL that points to a dbt project. | ||
|
||
### Additional configuration | ||
- Log into dbt Cloud using [OAuth connections](/docs/cloud/git/connect-github) to integrate with your source code platform. It automatically links to the repository using one of the native integrations set at the account level. <Lifecycle status='enterprise' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a bullet point? It's under a different header and it doesn't line up with the bullets under #2 if it's supposed to be a part of that I think we should remove the header and line it up, otherwise we can probably remove the bullet and make it a paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's an optional config so it is a step for those that are enterprise. that's why i initially had it as a numbered bullet. i think removing the header hides it a little and i'd like to make this optional config more visible. maybe i can combine both and number it as a 1:
Additional configuration
- Log into dbt Cloud using OAuth connections to integrate with your source code platform. It automatically links to the repository using one of the native integrations set at the account level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Verified confetti component still works after the updates 🚢🚢🚢
merging this now |
this pr adds a new guide helping users understand the considerations needed when they move from core to cloud.
it lays out what requirements are needed, any differences, and more.
this guide will follow up with two more guides pending review.
Resolves #5068