Vale: test with one file #5933
Vale: test with one file #5933
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
There was a problem hiding this comment.
this is amazing, @mirnawong1 !
a couple of questions:
-
since this is just a warning not an error, should the CI check still show up as failed/red? for only warnings, i expected pass/green.
-
i took a look at the Vale details log. i see that "reviewdog" errored out (screenshot below), which was unexpected to me. is this normal/expected behavior?
| @@ -9,7 +9,7 @@ Trusted adapters take part in the Trusted Adapter Program, including a commitmen | |||
|
|
|||
| Free and open-source tools for the data professional are increasingly abundant. This is by-and-large a *good thing*, however it requires due diligence that wasn't required in a paid-license, closed-source software world. As a user, there are questions to answer important before taking a dependency on an open-source project. The trusted adapter designation is meant to streamline this process for end users. | |||
|
|
|||
| ### Trusted adapter specifications | |||
| ### Trusted Adapter Specifications | |||
|
|
|||
There was a problem hiding this comment.
love the Vale warning for line 12!
github-actions
bot
removed
the
size: x-small
github-actions
bot
added
the
size: small
github-actions
bot
added
size: x-small
|
closing as this is a test pr and most of the testing is being done #5934 |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
github-actions
bot
added
size: small
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
What are you changing in this pull request and why?
Test linter with just one file and one line edit