-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated constraints doc following slack #5995
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @nataliefiann With the current update, the explanation and example only show when we select "Snowflake" under "Platform-specific support". Would it be possible to have the header "Custom constraints on models for advanced configuration of tables" not being specific to Snowflake? While the examples we have are Snowflake only here, the overall mechanism of custom constraints would work across all data warehouses. With the current update, non Snowflake users would likely never see the doc on custom constraints. |
|
||
:::info | ||
|
||
Each data warehouse has its own set of parameters that can be set for columns in their CTAS statements. For example for [DBX](https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-ddl-create-table-using.html) for [BigQuery](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#column_name_and_column_schema). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment in the PR discussion, but I don't think that adding information to other data warehouses is relevant if we are currently only showing those docs when people select Snowflake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nataliefiann ! have added my suggestions/feedback!
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Is there a preview to look at? |
hey @b-per - yes! here's the preview for you: https://docs-getdbt-khhsr2j4f-dbt-labs.vercel.app/reference/resource-properties/constraints#custom-constraints |
hey @nataliefiann @b-per - is this pr ok now? |
What are you changing in this pull request and why?
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pagesI'm creating this PR following Slack convo: https://dbt-labs.slack.com/archives/C02NCQ9483C/p1724830886150839 which Benoit advised there's no example in the docs of custom constraints.