Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated doc to be more to date with v1.9 #6125

Closed
wants to merge 2 commits into from

Conversation

nataliefiann
Copy link
Contributor

I've created this pull request following a suggestion from Leona here: https://dbt-labs.slack.com/archives/C02NCQ9483C/p1727101696314629 so that doc / section is up to date with v1.9

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@nataliefiann nataliefiann requested a review from a team as a code owner September 24, 2024 10:40
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 24, 2024 8:45pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 24, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , thanks for opening this up! I've approved it, however, i highly recommend either:

  • using a partial reusable to convey the same information in the model contracts page AND the version page so you only have to update the content in one place, rather than manually do it in two places or remember to do it in two places.
  • alternatively, you can link to the version page from the contract page so it's less manual maintenance and since the model contracts page doesn't include the examples.

Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@nataliefiann
Copy link
Contributor Author

Closed off as Core project has been paused

@runleonarun runleonarun reopened this Oct 1, 2024
@runleonarun runleonarun closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants