add trust signals to explorer #6141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
| <Lightbox src="/img/docs/collaborate/dbt-explorer/trust-signals-degraded.jpg" width="50%" title="Degraded trust signal icon"/> | ||
|
|
||
| #### Unknown | ||
| - Health information is unknown because the resource hasn't been run recently. |
There was a problem hiding this comment.
What is "recently" in this case? I'm assuming if the resource has never been run before (which we should mention), but in the above, not running in 30 days is a caution, so how long must it be to revert to "unknown"?
| - Is missing a description | ||
| - Does not have any tests configured | ||
| - Has been built in the past 30 day | ||
| <Lightbox src="/img/docs/collaborate/dbt-explorer/trust-signal-caution.png" title="Caution trust signal icon"/> |
There was a problem hiding this comment.
We might want to get product to update the text in the screenshots because this is really confusing when it says the resource is "caution" because it successfully ran on it's last run. Are these fields dynamic - when it's caution does it change the fields that put it in caution only or does it display the same text all the time?
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
….com into mwong-trust-signals
github-actions
bot
added
size: medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds info and icons related to trust signals, available in preview.
to be merged sept 30th