Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trust signals to explorer #6141

Merged
merged 21 commits into from
Oct 2, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Sep 25, 2024

this pr adds info and icons related to trust signals, available in preview.

to be merged sept 30th

@mirnawong1 mirnawong1 requested a review from a team as a code owner September 25, 2024 10:49
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 2, 2024 9:29am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Sep 25, 2024
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
<Lightbox src="/img/docs/collaborate/dbt-explorer/trust-signals-degraded.jpg" width="50%" title="Degraded trust signal icon"/>

#### Unknown
- Health information is unknown because the resource hasn't been run recently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "recently" in this case? I'm assuming if the resource has never been run before (which we should mention), but in the above, not running in 30 days is a caution, so how long must it be to revert to "unknown"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roxi addressing

- Is missing a description
- Does not have any tests configured
- Has been built in the past 30 day
<Lightbox src="/img/docs/collaborate/dbt-explorer/trust-signal-caution.png" title="Caution trust signal icon"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to get product to update the text in the screenshots because this is really confusing when it says the resource is "caution" because it successfully ran on it's last run. Are these fields dynamic - when it's caution does it change the fields that put it in caution only or does it display the same text all the time?

mirnawong1 and others added 6 commits September 27, 2024 09:40
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Sep 27, 2024
@mirnawong1 mirnawong1 merged commit 9d65c69 into mwong-explorer-previews-main Oct 2, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the mwong-trust-signals branch October 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants