Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new recommended syntax for foreign_key constraints #6189

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Document new recommended syntax for foreign_key constraints #6189

merged 9 commits into from
Oct 1, 2024

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Oct 1, 2024 •
edited by mirnawong1
Loading

What are you changing in this pull request and why?

Update documentation on constraints to prominently feature new recommended syntax for defining foreign_key constraints.

Resolves #5983

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@jtcohen6 jtcohen6 requested a review from a team as a code owner October 1, 2024 13:06
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 1, 2024 9:31pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Oct 1, 2024
@jtcohen6 jtcohen6 mentioned this pull request Oct 1, 2024
Closed
3 tasks
mirnawong1
mirnawong1 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one question about whether we should versionblock the section introducing the two new keys accepted by the foreign_key key

@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Oct 1, 2024

Thank you for spotting + fixing @mirnawong1!

@jtcohen6 jtcohen6 enabled auto-merge (squash) October 1, 2024 21:27
@jtcohen6 jtcohen6 merged commit 13bab21 into current Oct 1, 2024
10 checks passed
@jtcohen6 jtcohen6 deleted the jerco/foreign-key-refs branch October 1, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Foreign key constraints support to (with ref) + to_columns
3 participants
@jtcohen6 @mirnawong1 @nataliefiann