Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing old API links #6199

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Changing old API links #6199

merged 6 commits into from
Oct 2, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Changes legacy API links to the newer V2 API.
Removed an old migration page

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner October 1, 2024 18:58
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 2, 2024 4:26pm

@github-actions github-actions bot added content Improvements or additions to content developer blog This content fits on the developer blog. Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 1, 2024
@matthewshaver
Apply suggestions from code review
ba618f6 
Changing links to proper new links
nghi-ly
nghi-ly reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left a few suggs for ya

website/docs/docs/dbt-versions/2022-release-notes.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/2023-release-notes.md Outdated
@@ -691,7 +691,7 @@ Archived release notes for dbt Cloud from 2023

**Beginning June 1, 2023,** developers on the dbt Cloud multi-tenant application will be able to self-serve access to their account’s run history through the dbt Cloud user interface (UI) and API for only 365 days, on a rolling basis. Older run history will be available for download by reaching out to Customer Support. We're seeking to minimize the amount of metadata we store while maximizing application performance.

Specifically, all `GET` requests to the dbt Cloud [Runs endpoint](https://docs.getdbt.com/dbt-cloud/api-v2-legacy#tag/Runs) will return information on runs, artifacts, logs, and run steps only for the past 365 days. Additionally, the run history displayed in the dbt Cloud UI will only show runs for the past 365 days.
Specifically, all `GET` requests to the dbt Cloud [Runs endpoint](https://docs.getdbt.com/dbt-cloud/api-v2#/) will return information on runs, artifacts, logs, and run steps only for the past 365 days. Additionally, the run history displayed in the dbt Cloud UI will only show runs for the past 365 days.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link text and the link URL doesn't seem to match. is there still a Runs endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but there is no landing page for it anymore. It will be on the sidebar. I guess we could just land on the first page in the runs list. I'll change it to that

website/docs/docs/dbt-versions/2023-release-notes.md Outdated
@@ -936,7 +936,7 @@ Archived release notes for dbt Cloud from 2023

This maximum limit applies to [multi-tenant instances](/docs/cloud/about-cloud/access-regions-ip-addresses) only, and _does not_ apply to single tenant instances.

Refer to the [Pagination](https://docs.getdbt.com/dbt-cloud/api-v2-legacy#section/Pagination) section for more information on this change.
Refer to the [Pagination](https://docs.getdbt.com/dbt-cloud/api-v2#/) section for more information on this change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i might be missing something. i don't see a Pagination section on https://docs.getdbt.com/dbt-cloud/api-v2#/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to scroll down to see it on the page we link to. Can't anchor link to it like we could in the old APIs. I know Gideon is working on enhancements

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see. i was looking at the sidebar.

as an idea, maybe "... Pagination section on the API v2 page ..." or something?

totally non-blocking.

nghi-ly
nghi-ly approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving! :shipit: left one n/b sugg in case it's helpful

@matthewshaver matthewshaver enabled auto-merge (squash) October 2, 2024 16:17
@matthewshaver matthewshaver merged commit a1ca53a into current Oct 2, 2024
6 checks passed
@matthewshaver matthewshaver deleted the api-update branch October 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content developer blog This content fits on the developer blog. Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @nghi-ly