-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional ratio metric example #6209
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example looks great!! I gave one small recommendation inline
</File> | ||
|
||
#### Example 2 | ||
This eample is a ratio metric that calculates the ratio of food orders to total orders, with a filter and alias applied to the numerator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just add a note at the end here to make explicit how this is different, something like:
"...with a filter and alias applied to the numerator. Note that in order to add these attributes you'll need to use an explicit key for the name
attribute, too."
this pr adds an additional ratio metric exmaple and explains the advanced keys for numerator/demonimator
slack thread