-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New state:modified.vars
selection method
#6222
Draft
dbeatty10
wants to merge
14
commits into
current
Choose a base branch
from
dbeatty10-patch-4
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate_modified_compare_vars behavior` flag (off by default)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
size: x-small
This change will take under 3 hours to fix.
labels
Oct 2, 2024
3 tasks
graciegoheen
reviewed
Oct 2, 2024
@@ -210,6 +210,7 @@ Because state comparison is complex, and everyone's project is different, dbt su | |||
- `state:modified.relation`: Changes to `database`/`schema`/`alias` (the database representation of this node), irrespective of `target` values or `generate_x_name` macros | |||
- `state:modified.persisted_descriptions`: Changes to relation- or column-level `description`, _if and only if_ `persist_docs` is enabled at each level | |||
- `state:modified.macros`: Changes to upstream macros (whether called directly or indirectly by another macro) | |||
- `state:modified.vars`: Changes to [`vars`](/docs/build/project-variables) that a node depends on (available in v1.9 or with [dbt Cloud Versionless](/docs/dbt-versions/upgrade-dbt-version-in-cloud#versionless) via the `state_modified_compare_vars` [behavior flag](/reference/global-configs/behavior-changes)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this vars + env_vars? or just vars?
runleonarun
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
3 tasks
github-actions
bot
added
size: small
This change will take 1 to 2 days to address
and removed
size: x-small
This change will take under 3 hours to fix.
labels
Oct 3, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
size: small
This change will take 1 to 2 days to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Closes: #6202
What are you changing in this pull request and why?
state:modified.vars
is a new selector, opt-in method behind thestate_modified_compare_vars
behavior flag (off by default).Details
Checklist