Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incremental-microbatch.md #6265

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Update incremental-microbatch.md #6265

merged 5 commits into from
Oct 9, 2024

Conversation

anouardbt
Copy link
Contributor

batch size seem to be required when I'm not doing it it gives me a compliation error error

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • [
    Screenshot 2024-10-09 at 10 38 34
    ] I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@anouardbt
Update incremental-microbatch.md
889dfed 
batch size seem to be required when I'm not doing it it gives me a compliation error error
@anouardbt anouardbt requested a review from a team as a code owner October 9, 2024 09:39
@welcome Welcome
Copy link

welcome bot commented Oct 9, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Oct 9, 2024 3:24pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 9, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed new contributor Label for first-time contributors labels Oct 9, 2024
@mirnawong1
Copy link
Contributor

thanks so much for opening this up @anouardbt ! I'm going to confirm this with the core team!

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 9, 2024
mirnawong1
mirnawong1 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed by @QMalcolm !

@mirnawong1 mirnawong1 merged commit 49060fe into current Oct 9, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the anouardbt-batch_size_update branch October 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anouardbt @mirnawong1 @runleonarun