Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model SQLs for Teradata #6286

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

adamtwo
Copy link
Contributor

@adamtwo adamtwo commented Oct 14, 2024

What are you changing in this pull request and why?

The original Teradata quickstart that we contributed before the launch had several discrepancies. This PR reflects the early feedback from the people who tried to complete the quickstart.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@adamtwo adamtwo requested a review from a team as a code owner October 14, 2024 21:57
Copy link

vercel bot commented Oct 14, 2024

Someone is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address labels Oct 14, 2024
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 16, 2024 8:36am

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @adamtwo thanks for openign this up! I've approved it but have a couple of small suggestions. i can't make those changes myself - can you make those tweaks on your end?

adamtwo and others added 2 commits October 16, 2024 11:30
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@adamtwo
Copy link
Contributor Author

adamtwo commented Oct 16, 2024

hey @adamtwo thanks for openign this up! I've approved it but have a couple of small suggestions. i can't make those changes myself - can you make those tweaks on your end?

Thanks for the suggestions, I've accepted them. I'm good to merge the PR.

@mirnawong1 mirnawong1 merged commit 8b43ca1 into dbt-labs:current Oct 17, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants