Update model SQLs for Teradata #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
content
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mirnawong1
reviewed
Oct 16, 2024
mirnawong1
reviewed
Oct 16, 2024
mirnawong1
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
hey @adamtwo thanks for openign this up! I've approved it but have a couple of small suggestions. i can't make those changes myself - can you make those tweaks on your end?
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Thanks for the suggestions, I've accepted them. I'm good to merge the PR. |
mirnawong1
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
The original Teradata quickstart that we contributed before the launch had several discrepancies. This PR reflects the early feedback from the people who tried to complete the quickstart.
Checklist