Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation about of batch_size supported values and default #6298

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix documentation about of batch_size supported values and default #6298

merged 1 commit into from
Oct 15, 2024

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Oct 15, 2024 •
edited
Loading

What are you changing in this pull request and why?

Our docs stated that we only support day, but we support hour, day, month, and year. Our docs also stated that batch_size will be defaulted to day. This is not true, it is a required value and will not be defaulted.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@QMalcolm
Fix documentation about of batch_size supported values and default
7b8fb37 
Our docs stated that we only support `day`, but we support `hour`, `day`,
`month`, and `year`. Our docs also stated that `batch_size` will be defaulted
to `day`. This is not true, it is a required value and will not be defaulted.
@QMalcolm QMalcolm requested a review from a team as a code owner October 15, 2024 21:33
@welcome Welcome
Copy link

welcome bot commented Oct 15, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 15, 2024 9:38pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 15, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 15, 2024
mirnawong1
mirnawong1 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @QMalcolm !

@mirnawong1 mirnawong1 merged commit 29fc1bc into current Oct 15, 2024
12 of 13 checks passed
@mirnawong1 mirnawong1 deleted the qmalcolm--fix-microbatch-batch-size-info branch October 15, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-per b-per b-per approved these changes

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QMalcolm @b-per @mirnawong1 @runleonarun