-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dbt_valid_to_current #6308
add dbt_valid_to_current #6308
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mirnawong1 grouping your outstanding questions into a handful of categories: Hardcoded SQL expressionsQuestion:
👍 Hardcoded expressions that work within the data platform is the only option that is available currently. The precise syntax will vary per warehouse, so Jinja within
|
@mirnawong1 I added the |
website/docs/reference/resource-configs/dbt_valid_to_current.md
Outdated
Show resolved
Hide resolved
thank you @dbeatty10 ! it looks like this is resolved now right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits!
website/docs/reference/resource-configs/dbt_valid_to_current.md
Outdated
Show resolved
Hide resolved
website/docs/reference/resource-configs/dbt_valid_to_current.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
grace reviewed and folded in nits
website/docs/reference/resource-configs/dbt_valid_to_current.md
Outdated
Show resolved
Hide resolved
website/docs/reference/resource-configs/dbt_valid_to_current.md
Outdated
Show resolved
Hide resolved
Check your created Crawler Check your created index on your Algolia Application |
adding new config for
dbt_valid_to_current
, which allows users to set a future date fordbt_valid_to
using the dbt_valid_to_current config in yaml/config/project.Resolves #6275
Outstanding questions:
✅ - Can date be hardcoded using this syntax? "to_date('2024-05-10')" or can they use "to_date('2024, 05, 10')" ?
✅ - is the syntax just a string (e.g.
dbt_valid_to_current: '9999, 12, 31'
) or must they useto_date
?✅ - can user use
var
to return a SQL statement '{{ var('my_future_date') }}'✅ - can they use a macro that returns a SQL statement '{{ dbt.date(9999, 12, 31) }}'?
✅ - how does this new config work with deferral/state:modified? will we warn users that the config has been updated and they need to manually update their snapshot?
🚀 Deployment available! Here are the direct links to the updated files: