Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline string property value parsing #59

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

dcronqvist
Copy link
Owner

Description

All string properties for the .tmx file format expected the string value to exist in the value attribute. However, for multiline string properties, the string value will be placed inbetween the property tags (body). This is addressed in this PR so that we properly parse multiline string properties without causing a crash.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • Tests have been added/updated to cover new functionality.
  • Documentation has been updated for all new changes (e.g., usage examples, API documentation).

@dcronqvist dcronqvist merged commit 080f95c into dev Nov 17, 2024
1 check passed
@dcronqvist dcronqvist deleted the fix-multiline-string-prop branch November 17, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TMX custom string properties with newlines are not properly handled
1 participant