Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object override for rectangle objects #60

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

dcronqvist
Copy link
Owner

Description

Due to not having an OverrideObject overload for rectangle objects, they would get stuck in an infinite recursion when performing overriding from templates. This has been fixed by adding a corresponding overload, and adding a test case map to make sure we do not regress.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • Tests have been added/updated to cover new functionality.
  • Documentation has been updated for all new changes (e.g., usage examples, API documentation).

@dcronqvist dcronqvist linked an issue Nov 17, 2024 that may be closed by this pull request
@dcronqvist dcronqvist merged commit 1e41443 into dev Nov 17, 2024
1 check passed
@dcronqvist dcronqvist deleted the overrideobject-bug branch November 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop in OverrideObject
1 participant