Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tick crash (fixes #73) #97

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

def-
Copy link
Member

@def- def- commented May 5, 2020

No description provided.

@fokkonaut
Copy link
Collaborator

why isnt this needed in ddnet6?

@def-
Copy link
Member Author

def- commented May 5, 2020

Not sure, have never seen this crash on DDNet6. Maybe we don't delete the player on SendMsg already, but do so later?

@fokkonaut
Copy link
Collaborator

fokkonaut commented May 5, 2020

Could you check it and apply the ddnet6 version? As I said in the issue, I just took the initial commit I think

EDIT: i dont understand where the player gets removed?

@def-
Copy link
Member Author

def- commented May 5, 2020

Hm, I also can't find a location where the player would get deleted. I'm just fishing in the dark here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants