Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keyboard shortcuts #186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

aruznieto
Copy link
Contributor

Add keyboard shortcuts to interface.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #184

Does this introduce a breaking change?

  • Yes
  • No

Migration to ES6

Now it is configured to use i18n translations. So we should accept first the PR #182

@dec0dOS
Copy link
Owner

dec0dOS commented Oct 19, 2023

Conflicting files should be resolved before merging the PR.

@aruznieto
Copy link
Contributor Author

I need to revise the changes, I do it on GH directly.

@aruznieto aruznieto marked this pull request as ready for review October 20, 2023 18:19
@dec0dOS
Copy link
Owner

dec0dOS commented Oct 21, 2023

SettingsComponent is still present in the code.

To maintain a smoother development process, I'd recommend following these steps:

  • Always create a new branch based on the current main branch.
  • Create a new branch for each new feature you're working on.

By doing this, you can easily synchronize your branches with the main branch and reduce the likelihood of conflicts with the base branch. It'll make the development process more efficient and collaborative

Copy link
Contributor Author

@aruznieto aruznieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants