Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intergrate ZeroNSd support #25

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mcondarelli
Copy link

@mcondarelli mcondarelli commented Oct 27, 2021

Pull request type

Early feedback

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No integration with ZeroNSd
No all-in-one Docker container

Issue Number: 14

What is the new behavior?

Integration with ZeroNSd
Experimental all-in-one Docker container (ZeroTier-One + ZeroUI + ZeroNSd)

Does this introduce a breaking change?

  • Yes
  • No

Note current ZeroUI is not fully compatible with ZeroTier Central API; I chose to modify ZeroNSd to adapt it to current
ZeroUI behavior, but "Right Ting" should be the other way around.

Other information

Please see Issue #14

Updated Network page
Updated save on db.json
backend/services/network.js implements correct handling of dns: stanza
required by ZeroNSd.

Unfortunately this breaks frontend.
I think this is because of delete statements.
Unfortunately I know too little about nodejs to implement a proper solution.
I tried mitigating problem using a copy of the data, but that didn't work.
Anything else coming to mind seems to ugly to be 'right'.
I am unsure about this solution: frontend writes to "additionalConfig"
but reads back from `config.dns` maintained by backend.
This creates a Docker container with ZeroTier-One, zero-ui and ZeroNSd
all-in-one solution.
It also includes a trivial fix to allow ZeroNSd to work with zero-ui.
@dec0dOS
Copy link
Owner

dec0dOS commented Dec 14, 2021

Hello, @mcondarelli.

I'm sorry for the late response. I've been thinking for some time about DNS implementation.
Starting processes this way may not be reliable in some cases. Did you use your fork for some time?
I'm leaning towards a solution with the additional microservice that handles all the zeronsd instances.

@faicker
Copy link

faicker commented Mar 16, 2022

Hello, any progress?

@dec0dOS
Copy link
Owner

dec0dOS commented Mar 16, 2022

Hello, @faicker
Currently no. Some refactoring should be done before implementing this feature.

@faicker
Copy link

faicker commented Mar 16, 2022

Thanks, waiting for it. @dec0dOS

@dec0dOS dec0dOS marked this pull request as draft July 28, 2022 14:36
@muhammadyusuf-kurbonov
Copy link

Any updates?

@chenxudong2020
Copy link
Contributor

I don't know why it wasn't merged, but I think we can modify zeroDNS and start a compatible Docker project to integrate it uniformly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants