Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #610 Fetch revisions by objectId and schemaName #611

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Fix #610 Fetch revisions by objectId and schemaName #611

merged 17 commits into from
Jan 9, 2024

Conversation

albinpa
Copy link
Contributor

@albinpa albinpa commented Jan 5, 2024

No description provided.

@albinpa albinpa added the bug Something isn't working label Jan 5, 2024
@albinpa albinpa self-assigned this Jan 5, 2024
georgepadayatti
georgepadayatti requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this PR into 13 commits - #610 (comment). This is too big a PR for me to review and approve.

@albinpa
Copy link
Contributor Author

albinpa commented Jan 5, 2024

Can we split this PR into 13 commits - #610 (comment). This is too big a PR for me to review and approve.

Ok.

albinpa added 17 commits January 5, 2024 13:56
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in revision pipeline
6c167d7
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config delete …
b987927 
…dataagreement
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config list da…
2a3c788 
…taagreement revisions
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config list da…
e4860ce 
…taagreements
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config read da…
0bdec5e 
…taagreement
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config delete …
c4a49c6 
…policy
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config list po…
7d10896 
…licy revisions
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in config read po…
131f49e 
…licy
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service create…
cdcbc85 
… blank signature object
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service create…
e31b192 
… dataagreement record
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service create…
2de0cd4 
… draft consent record
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service list d…
e149796 
…ataattributes for dataagreement
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service read d…
15e0ef3 
…ataagreement
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service update…
04e529b 
… dataagreement record
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service update…
9c5bd1b 
… signature object
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in verification f…
3ca9d42 
…etch dataagreement record
@albinpa
Fix #610 Fetch revisions by objectId and schemaName in service read p…
81ea1e9 
…olicy
@georgepadayatti
Copy link
Member

Can you share instructions to run the test suite to test the changes ?

@albinpa
Copy link
Contributor Author

albinpa commented Jan 9, 2024 •
edited by georgepadayatti
Loading

Can you share instructions to run the test suite to test the changes ?

Yes.

  1. Make deployable docker image from main branch of bb-consent-api by executing make build/docker/deployable command
  2. Copy image name and paste it in image fields value under api in test-docker-compose.yaml file inside test folder in bb-consent-playground
  3. Execute the following commands in bb-consent-playground
  4. make destroy
  5. make build-fixtures
  6. make build-test
  7. make setup-test
  8. make run-test
  9. Make deployable docker image from fix/610 branch by executing make build/docker/deployable command in fix/610 branch
  10. Copy image name and paste it in image fields value under api in test-docker-compose.yaml file inside test folder in bb-consent-playground
  11. Execute the following commands in bb-consent-playground
  12. make destroy
  13. make setup-test
  14. make run-test-behave

@georgepadayatti
Copy link
Member

2024-01-09_21-45

Tests have passed

@georgepadayatti georgepadayatti merged commit 95c9ed8 into main Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgepadayatti georgepadayatti georgepadayatti approved these changes

Assignees

@albinpa albinpa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albinpa @georgepadayatti