Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #612 Revisions #613

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add #612 Revisions #613

merged 1 commit into from
Jan 11, 2024

Conversation

albinpa
Copy link
Contributor

@albinpa albinpa commented Jan 10, 2024

No description provided.

@albinpa albinpa added the enhancement New feature or request label Jan 10, 2024
@albinpa albinpa self-assigned this Jan 10, 2024
@albinpa
Copy link
Contributor Author

albinpa commented Jan 10, 2024

Instructions to run bdd test case ,

  1. Make deployable docker image from main branch of bb-consent-api by executing make build/docker/deployable command
  2. Copy image name and paste it in image fields value under api in test-docker-compose.yaml file inside test folder in bb-consent-playground
  3. Execute the following commands in bb-consent-playground
  4. make destroy
  5. make build-fixtures
  6. make build-test
  7. make setup-test
  8. make run-test
  9. Make deployable docker image from feature/612 branch by executing make build/docker/deployable command in feature/612 branch
  10. Copy image name and paste it in image fields value under api in test-docker-compose.yaml file inside test folder in bb-consent-playground
  11. Execute the following commands in bb-consent-playground
  12. make destroy
  13. make setup-test
  14. make run-test

@georgepadayatti
Copy link
Member

I ran the tests from the main branch, and some failed as shown in the screenshot below. But the error is due to the 500 status code. This should not happen, instead, the response returned can contain an older field and fail due to that.

Can you check this ?

2024-01-10_15-28

@albinpa
Copy link
Contributor Author

albinpa commented Jan 10, 2024

I ran the tests from the main branch, and some failed as shown in the screenshot below. But the error is due to the 500 status code. This should not happen, instead, the response returned can contain an older field and fail due to that.

Can you check this ?

The schemaName of data agreement in test data has the value DataAgreement when trying to fetch revision using schemaName and objectId in delete data agreement in the main branch which has schemaName as dataAgreement, the API responds with 500 Failed to fetch revision error, that's why the test fails.

Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance criteria for this PR to be merged: link

Do implement the steps for the validating the above criteria against fix branch.

internal/revision/revisions.go Outdated Show resolved Hide resolved
Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance criteria is met.

2024-01-11_15-17

@georgepadayatti georgepadayatti merged commit e511fcd into main Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants