Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible way of adding gcc 2.5.7 #11

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Conversation

fuerchter
Copy link
Contributor

Not sure how correct this is though, so feel free to try it your own way!

@Xeeynamo
Copy link
Collaborator

Xeeynamo commented Oct 8, 2023

This now needs a rebase on master

@fuerchter
Copy link
Contributor Author

Hi,
I did so just now. As far as gcc-2.5.7-psx goes, it currently emits the following warnings when compiling:

*Initialization*:1: warning: `__SIZE_TYPE__' redefined
*Initialization*:1: warning: `__PTRDIFF_TYPE__' redefined

But still runs fine otherwise. I'm not sure how to address it.
Did the little endian changes (or some other change) affect the memcpy issue I mentioned in discord here? Switching between 2.6.3-psx and 2.6.3 on decomp.me does not cause them anymore.

@Xeeynamo
Copy link
Collaborator

Hi, I did so just now. As far as gcc-2.5.7-psx goes, it currently emits the following warnings when compiling:

*Initialization*:1: warning: `__SIZE_TYPE__' redefined
*Initialization*:1: warning: `__PTRDIFF_TYPE__' redefined

But still runs fine otherwise. I'm not sure how to address it. Did the little endian changes (or some other change) affect the memcpy issue I mentioned in discord here? Switching between 2.6.3-psx and 2.6.3 on decomp.me does not cause them anymore.

I wouldn't mind it too much. If it works, it works. If there are any breaking issues we can always fix them later on. Are we good to merge it?

@fuerchter
Copy link
Contributor Author

Yep, feel free to do so.

@Xeeynamo Xeeynamo merged commit 4970c9a into decompals:master Oct 16, 2023
13 checks passed
@mkst
Copy link
Contributor

mkst commented Oct 17, 2023

Thanks for this, I was holding off as I wasn't sure about the change to the varargs, I spent an hour or so trying to backport the changes but ran out of steam. We'll just handle that if it becomes an issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants