Update fa.json #1138
Open
Update fa.json #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Added missing lines. *Improved existing translations. *Fully aligned with en.json file. *Used phrases popular in persian crypto communities.
jholdstock
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Technical review
All new strings are displayed OK on the site. All HTML elements embedded in the strings are proper. A few minor in-line suggestions made for extra \n new line characters which are unnecessary.
In order for Persian to be added to the language dropdown, please add the following segment to the bottom of src/config.yml:
fa:
contentDir: content/fa
languageName: فارسی
weight: 140
params:
languageDir: rtl
jholdstock
reviewed
Dec 14, 2023
add fa to config.yml
|
All suggestions were taken into effect. I know it's been a long time since the review and the pull request was taken place, and the site has changed a lot. I thought I could go step by step and finish what I started first. I was thinking Maybe syncing translation with the last en.json file in a new pull request is a good idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I had to close the last PR.
I used ChatGPT to review my translation. It compared the en and fa texts for each line of text and didn't find any errors. The output is attached here. CHATGPT-REVIEW.md
To reproduce it:
1.Paste this query to Chatgpt and press enter:
I have two texts both use json and html formats. first one is the original which is in english. the second is translated in persian. Review the persian and compare it with the english one in terms of translation. I'm first pasting the english.
2.Paste the en.json content and press enter.
3.Paste the fa.json content and press enter.