Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Cell types with Arc/RwLock to make interior mutability thread safe #129

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

marvin-hansen
Copy link
Member

…d safe.

Replaced Cell types with Arc/RwLock to make interior mutability thread safe for usage in Tokio runtime.

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

  • I have signed the DCO?
  • All tests are passing when running make test?
  • No errors or security vulnerabilities are reported by make check?

For details on make, please see BUILD.md

Note: The CI runs all of the above and fixing things before they hit CI speeds
up the review and merge process. Thank you.

…d safe.

Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
@marvin-hansen marvin-hansen self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (12db26c) 87.85% compared to head (c9f5160) 87.77%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ty/src/types/reasoning_types/causaloid/causable.rs 55.00% 9 Missing ⚠️
...ity/src/types/reasoning_types/causaloid/getters.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   87.85%   87.77%   -0.08%     
==========================================
  Files         123      123              
  Lines        3235     3223      -12     
==========================================
- Hits         2842     2829      -13     
- Misses        393      394       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marvin-hansen marvin-hansen merged commit 45b4763 into deepcausality-rs:main Jan 25, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant