Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: dropped support for graphql secrets and variables #86

Merged
merged 12 commits into from
Oct 3, 2024
Merged

refactor: dropped support for graphql secrets and variables #86

merged 12 commits into from
Oct 3, 2024

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Oct 2, 2024 •
edited
Loading

changes

  • added crypt + jwt packages
  • added function to decode token
  • removed graphql request
  • added rest API platform secret method
  • patched construction of pydantic types for variables and secrets
  • updated codeowners
  • updated docs to take into account refactoring of utils
  • refactored utils
  • disabled some tests

@sg-s sg-s requested a review from a team as a code owner October 2, 2024 01:25
@sg-s sg-s self-assigned this Oct 2, 2024
@sg-s sg-s requested a review from a team as a code owner October 3, 2024 15:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 3, 2024
View reviewed changes
src/utils/core.py Outdated

tokens = read_cached_tokens()

return jwt.decode(tokens["access"], options={"verify_signature": False})

Check failure

Code scanning / SonarCloud

JWT should be signed and verified High

Don't use a JWT token without verifying its signature. See more on SonarCloud
jonrkarr
jonrkarr reviewed Oct 3, 2024
View reviewed changes
src/platform/api.py Outdated Show resolved Hide resolved
@sg-s sg-s marked this pull request as draft October 3, 2024 17:12
sg-s
sg-s commented Oct 3, 2024
View reviewed changes
src/auth.py Show resolved Hide resolved
src/auth.py Show resolved Hide resolved
src/cli/config.py Show resolved Hide resolved
src/cli/config.py Show resolved Hide resolved
src/config/__init__.py Show resolved Hide resolved
src/utils/core.py Outdated Show resolved Hide resolved
src/utils/core.py Show resolved Hide resolved
src/variables/core.py Show resolved Hide resolved
tests/test_variables.py Show resolved Hide resolved
tests/test_variables.py Show resolved Hide resolved
@sg-s sg-s marked this pull request as ready for review October 3, 2024 18:30
@sg-s sg-s changed the title fix: better error message on failed file upload refactor: dropped support for graphql secrets and variables Oct 3, 2024
@sg-s sg-s enabled auto-merge (squash) October 3, 2024 18:47
@sg-s sg-s merged commit d16058f into main Oct 3, 2024
12 checks passed
@sg-s sg-s deleted the variables-secrets branch October 3, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrkarr jonrkarr jonrkarr approved these changes

@kennyjwilli kennyjwilli kennyjwilli approved these changes

Assignees

@sg-s sg-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sg-s @kennyjwilli @jonrkarr