CI: test all DNS records

deltachat · Dec 17, 2024 · 1a750d7 · 1a750d7
1 parent 26491cd
commit 1a750d7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/test-and-deploy-ipv4only.yaml b/.github/workflows/test-and-deploy-ipv4only.yaml
@@ -96,5 +96,5 @@ jobs:
         run: CHATMAIL_DOMAIN2=nine.testrun.org cmdeploy test --slow
 
       - name: cmdeploy dns
-        run: cmdeploy dns -v
+        run: cmdeploy dns -v --all
 
diff --git a/.github/workflows/test-and-deploy.yaml b/.github/workflows/test-and-deploy.yaml
@@ -94,5 +94,5 @@ jobs:
         run: CHATMAIL_DOMAIN2=nine.testrun.org cmdeploy test --slow
 
       - name: cmdeploy dns
-        run: cmdeploy dns -v
+        run: cmdeploy dns -v --all
 
diff --git a/cmdeploy/src/cmdeploy/dns.py b/cmdeploy/src/cmdeploy/dns.py
@@ -55,11 +55,13 @@ def check_full_zone(sshexec, remote_data, out, zonefile, all) -> int:
         for line in required_diff:
             out(line)
         print()
-        returncode += 1
+        returncode = 1
     if recommended_diff and (all or not required_diff):
         out("WARNING: these recommended DNS entries are not set:\n")
         for line in recommended_diff:
             out(line)
+        if all:
+            returncode = 1
 
     if not (recommended_diff or required_diff):
         out.green("Great! All your DNS entries are verified and correct.")