Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS: fix checking for required DNS records #412

Merged
merged 7 commits into from
Sep 13, 2024
Merged

DNS: fix checking for required DNS records #412

merged 7 commits into from
Sep 13, 2024

Conversation

missytake
Copy link
Contributor

No description provided.

@missytake missytake changed the title Improve README for first setup DNS: fix checking for required DNS records Sep 13, 2024
@missytake missytake changed the title DNS: fix checking for required DNS records WIP: DNS: fix checking for required DNS records Sep 13, 2024
@missytake missytake changed the title WIP: DNS: fix checking for required DNS records DNS: fix checking for required DNS records Sep 13, 2024
@missytake
Copy link
Contributor Author

I have no idea why those two CI checks fail. Locally they pass for me. As it's just lint, I propose to ignore them and merge this PR nonetheless.

@link2xt
Copy link
Contributor

link2xt commented Sep 13, 2024 •
edited
Loading

I have no idea why those two CI checks fail. Locally they pass for me. As it's just lint, I propose to ignore them and merge this PR nonetheless.

No, it is this PR that broke the lint. On main it passes. You can fix by running ruff check --fix chatmaild/
Maybe your ruff version is different, you can upgrade it inside venv with pip install ruff --upgrade. Should be 0.6.4.

@missytake missytake merged commit ba811c2 into main Sep 13, 2024
6 checks passed
@missytake missytake deleted the readme-dns branch September 13, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@link2xt link2xt link2xt approved these changes

@hpk42 hpk42 Awaiting requested review from hpk42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@missytake @link2xt