feat: Assign message to ad-hoc group with matching name and members (#5385) #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/ignore-member-removal
branch
from
6888326
to
c532f4c
Compare
iequidoo
force-pushed
the
iequidoo/assign-to-similar-adhoc-grp
branch
from
8a6fa11
to
6b0bff1
Compare
iequidoo
force-pushed
the
iequidoo/assign-to-similar-adhoc-grp
branch
from
6b0bff1
to
6bd9681
Compare
|
Btw, i just received several mails from github and that's how it looks curently: EDIT: I checked, Gmail app does the same as this PR apparently, it merges threads with the same Subject and participants. |
iequidoo
force-pushed
the
iequidoo/assign-to-similar-adhoc-grp
branch
from
6bd9681
to
683c681
Compare
iequidoo
force-pushed
the
iequidoo/assign-to-similar-adhoc-grp
branch
2 times, most recently
from
5991a16
to
363aa23
Compare
link2xt
approved these changes
Sep 21, 2024
iequidoo
force-pushed
the
iequidoo/assign-to-similar-adhoc-grp
branch
from
363aa23
to
a7aaef2
Compare
link2xt
approved these changes
Sep 26, 2024
…5385) This should fix ad-hoc groups splitting when messages are fetched out of order from different folders or otherwise reordered, or some messages are missing so that the messages reference chain is broken, or a member was removed from the thread and readded later, etc. Even if this way two different threads are merged, it looks acceptable, having many threads with the same name/subject and members isn't a common use case.
iequidoo
force-pushed
the
iequidoo/assign-to-similar-adhoc-grp
branch
from
a7aaef2
to
e94af72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5385