Small change for #5999 #6047
Closed
Small change for #5999 #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test on what happens currently when apps call `markseen_msgs()` for not downloaded messages. Such messages are marked as seen, but MDNs aren't sent for them. This is probably correct, but when a message is downloaded, its state should be downgraded to `InNoticed` and when the user really sees it, the app should issue `markseen_msgs()` again and that should trigger sending an MDN. Currently when such a message is downloaded, it remains `InSeen`.
link2xt
changed the base branch from
main
to
iequidoo/markseen_not_downloaded_msg
iequidoo
reviewed
Oct 16, 2024
| @@ -1014,15 +1014,16 @@ async fn add_parts( | |||
| } | |||
| } | |||
|
|
|||
| state = if (seen && replace_msg_id.is_none()) | |||
| state = if replace_msg_id.is_some() { | |||
There was a problem hiding this comment.
Not sure that the code can be rewritten this way. If a message is replaced, that doesn't mean it's already noticed. Maybe it's replaced because DownloadLimit was changed and the message was resent. But i didn't test such a scenario, so i decided not to change the code here too much
| @@ -1564,7 +1565,7 @@ INSERT INTO msgs | |||
| ON CONFLICT (id) DO UPDATE | |||
| SET rfc724_mid=excluded.rfc724_mid, chat_id=excluded.chat_id, | |||
| from_id=excluded.from_id, to_id=excluded.to_id, timestamp_sent=excluded.timestamp_sent, | |||
| type=excluded.type, state=min(state,max(?,13)), msgrmsg=excluded.msgrmsg, | |||
| type=excluded.type, state=min(state,excluded.state), msgrmsg=excluded.msgrmsg, | |||
There was a problem hiding this comment.
As for this, i agree that excuded.state should be used instead of ?, but i prefer to have max(...,13) here because we never want to downgrade the state to InFresh. So this is a bit cumbersome, but more straightforward
iequidoo
force-pushed
the
iequidoo/markseen_not_downloaded_msg
branch
2 times, most recently
from
f2abfd5
to
1a7f108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5999