Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent accidental wrong-password-notifications #6122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Oct 28, 2024

Over the past years, it happend two times that a user came to me worried about the "Cannot login as ***. Please check if the e-mail address and the password are correct." message.

I'm not sure why this happened, but I think we should make the logic for showing this notification stricter:

  • Before: The notification is shown if connection fails two times in a row, and the second error contains the word "authentication".
  • Now: The notification is shown if the connection fails two times in a row, and both error messages contain the word "authentication".

The second commit just renames login_failed_once to authentication_failed_once in order to reflect this change.

Over the past years, it happend two times that a user came to me worried about the "Cannot
login as ***. Please check if the e-mail address and the password are
correct." message.

I'm not sure why this happened, but I think we should make the logic for
showing this notification stricter:
- Before: The notification is shown if connection fails two times in a row, and
  the second error contains the word "authentication".
- Now: The notification is shown if the connection fails two times in a row,
  and _both_ error messages contain the word "authentication".

The second commit just renames `login_failed_once` to
`authentication_failed_once` in order to reflect this change.
@Hocuri Hocuri changed the title [WIP] fix: Prevent accidental wrong-password-notifications fix: Prevent accidental wrong-password-notifications Oct 29, 2024
@Hocuri Hocuri requested review from iequidoo and link2xt and removed request for iequidoo October 29, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants