fix: Prevent accidental wrong-password-notifications #6122
+28
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the past years, it happend two times that a user came to me worried about the "Cannot login as ***. Please check if the e-mail address and the password are correct." message. I'm not sure why this happened, but I think we should make the logic for showing this notification stricter: - Before: The notification is shown if connection fails two times in a row, and the second error contains the word "authentication". - Now: The notification is shown if the connection fails two times in a row, and _both_ error messages contain the word "authentication". The second commit just renames `login_failed_once` to `authentication_failed_once` in order to reflect this change.
Hocuri
changed the title
Hocuri
requested review from
iequidoo and
link2xt
and removed request for
iequidoo
iequidoo
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the past years, it happend two times that a user came to me worried about the "Cannot login as ***. Please check if the e-mail address and the password are correct." message.
I'm not sure why this happened, but I think we should make the logic for showing this notification stricter:
The second commit just renames
login_failed_oncetoauthentication_failed_oncein order to reflect this change.