Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable jsx namespace support by default (#154) #155

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat: enable jsx namespace support by default (#154) #155

merged 2 commits into from
Sep 5, 2023

Conversation

jollytoad
Copy link
Contributor

Enables support for JSX namespaces by setting throw_if_namespace to false.
Also added test for namespace on tag and attribute.

Closes #154

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jollytoad jollytoad mentioned this pull request Sep 1, 2023
Closed
dsherret
dsherret approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks!

@dsherret dsherret merged commit f5ee173 into denoland:main Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable JSX Namespace by default
3 participants
@jollytoad @CLAassistant @dsherret