feat: add Emitter and emit feature
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to emit any program. Previously `deno_ast` could only emit programs it also transformed to JS.
dsherret
reviewed
Apr 10, 2024
|
|
||
| /// Source emitted based on the emit options. | ||
| #[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Clone, Debug)] | ||
| pub struct EmittedSource { |
There was a problem hiding this comment.
Move above Emitter so that the impl of Emitter is not separated by this?
src/emit.rs
Outdated
| } | ||
|
|
||
| impl Emitter { | ||
| pub fn new(specifier: &str, source: String, options: EmitOptions) -> Self { |
There was a problem hiding this comment.
We changed deno_ast to work completely off ModuleSpecifiers. Let's change specifier: &str to an owned specifier: ModuleSpecifier
There was a problem hiding this comment.
It's only used to construct the source map, and for NPM transpile I need the ability to specify a relative path as the source map path. Hence why this is a string instead of a module specifier
github-merge-queue bot
pushed a commit
to jsr-io/jsr
that referenced
this pull request
Apr 17, 2024
This fixes various bugs, and introduces some features. Specifically: - Source code is now included in the bundle to enable better "Go to source definition" - More usecases using `/// <reference types="..." />` work correctly now, especially when d.ts file is not a sibling of the JS file. - We strip `/// <reference types="..." />` out of JS files correctly now. - We transpile `npm:` and `jsr:` specifiers in user provided `.d.ts` files now. Fixes #367 Fixes #372 Fixes #364 Fixes #313 Fixes #180 Fixes #216 Fixes #326 ~~Blocked on landing denoland/deno_ast#230 and denoland/deno_graph#429 Landed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to emit any program. Previously
deno_astcould only emit programs it also transformed to JS.