feat: support string concat in dynamic import analysis #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`import("./foo/" + value)` is now supported in addition to ``import(`./foo/${value}`)``.
lucacasonato
commented
May 23, 2024
Comment on lines
+303
to
+305
| let cooked = tpl.quasis[i].cooked.as_ref().unwrap(); | ||
| if cooked.len() > 0 { | ||
| parts.push(DynamicTemplatePart::String(cooked.clone())); |
There was a problem hiding this comment.
@dsherret PTAL - the previous code was incorrect. Raw includes escape sequences in raw form.
marvinhagemeister
approved these changes
May 23, 2024
dsherret
reviewed
May 23, 2024
| @@ -308,6 +311,47 @@ impl<'a> Visit for DependencyCollector<'a> { | |||
| DynamicArgument::Template(parts) | |||
| } | |||
| } | |||
| Expr::Bin(bin) => { | |||
| let mut parts = Vec::with_capacity(2); | |||
There was a problem hiding this comment.
Capacity is not necessarily correct here I think?
There was a problem hiding this comment.
Oh, I guess this is just allocating for the common case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import("./foo/" + value)is now supported in addition toimport(`./foo/${value}`).