fix(tar): ignore non-tar file portion of a stream in UntarStream
#6064
+108
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be exactly the right amount of bytes - The spec specifies that a tar file ends with 1024 bytes of `0b00`, but it says nothing about extra information being stored after this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6064 +/- ##
=======================================
Coverage 96.75% 96.76%
=======================================
Files 508 508
Lines 39132 39140 +8
Branches 5786 5793 +7
=======================================
+ Hits 37864 37872 +8
Misses 1226 1226
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
changed the title
UntarStream bugUntarStream
iuioiua
changed the title
UntarStreamUntarStream
iuioiua
suggested changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: denoland/wasmbuild#143
This pull request fixes a bug with the
UntarStreamclass where it incorrectly assumes the contents of a stream will only contain a tar file. This is incorrect as anything after a tar file can be appended and a valid tar decoder should ignore everything after it receives its 1024 bytes of0b00when checking for a header.The changes made here should check for a premature ending and if so send a cancel signal upstream so if a readable stream being pipped in intentionally had multiple stuff appended together, it can listen for that and then switch to whatever.