Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): support expect.objectContaining #6065

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

eryue0220
Copy link
Contributor

Part of #3964, support expect.objectContaining api

…deno_std into feat/expect-object-containing

* 'feat/expect-object-containing' of github.com:eryue0220/deno_std:
  BREAKING(io): remove `StringReader` (denoland#6062)
  BREAKING(io): remove `StringWriter` (denoland#6061)
  BREAKING(io): remove `MultiReader` (denoland#6059)
  BREAKING(io): remove `LimitedReader` (denoland#6058)
  chore: fix heading level in Releases.md (denoland#6044)
  BREAKING(io): remove `readDelim()` (denoland#6052)
  BREAKING(io): remove `BufWriter` (denoland#6057)
  BREAKING(io): remove `BufReader` (denoland#6056)
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (d902c24) to head (e1a8d82).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6065      +/-   ##
==========================================
- Coverage   96.76%   96.58%   -0.18%     
==========================================
  Files         508      536      +28     
  Lines       39101    40649    +1548     
  Branches     5786     6101     +315     
==========================================
+ Hits        37836    39262    +1426     
- Misses       1225     1343     +118     
- Partials       40       44       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title feat(expect): support expect.objectContaining fix(expect): support expect.objectContaining Oct 21, 2024
@kt3k kt3k mentioned this pull request Oct 21, 2024
20 tasks
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@kt3k kt3k merged commit ae7048f into denoland:main Oct 21, 2024
19 checks passed
@eryue0220 eryue0220 deleted the feat/expect-object-containing branch October 22, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants