Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(log): document BaseHandler #6067

Merged
merged 3 commits into from
Sep 27, 2024
Merged

docs(log): document BaseHandler #6067

merged 3 commits into from
Sep 27, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Sep 27, 2024

Towards #3764

@iuioiua iuioiua requested a review from kt3k as a code owner September 27, 2024 00:34
@iuioiua iuioiua enabled auto-merge (squash) September 27, 2024 00:34
@github-actions github-actions bot added the log label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (d902c24) to head (45b7e70).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6067      +/-   ##
==========================================
- Coverage   96.76%   96.71%   -0.06%     
==========================================
  Files         508      508              
  Lines       39101    39139      +38     
  Branches     5786     5786              
==========================================
+ Hits        37836    37852      +16     
- Misses       1225     1245      +20     
- Partials       40       42       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit e971672 into main Sep 27, 2024
16 checks passed
@iuioiua iuioiua deleted the doc-base-handler branch September 27, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants