Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections/unstable): support Iterable argument in dropLastWhile() #6076

Merged

Conversation

Liam-Tait
Copy link
Contributor

@Liam-Tait Liam-Tait commented Sep 28, 2024

Create a backwards compatible unstable version of dropLastWhile() that accepts an iterable.

Slight modification to the loop to avoid the offset - 1 calculation each loop.

#5470

  • Remove the test benchmark before merging

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (ea85486) to head (2643b40).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6076      +/-   ##
==========================================
- Coverage   96.75%   96.74%   -0.01%     
==========================================
  Files         508      509       +1     
  Lines       39140    39154      +14     
  Branches     5793     5795       +2     
==========================================
+ Hits        37869    37880      +11     
- Misses       1229     1232       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Liam-Tait Liam-Tait force-pushed the liam/collections-drop-last-while-iterable branch from d29cb54 to 2557b7c Compare September 28, 2024 09:08
@Liam-Tait Liam-Tait marked this pull request as ready for review October 1, 2024 09:00
@Liam-Tait Liam-Tait requested a review from kt3k as a code owner October 1, 2024 09:00
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 8abe412 into denoland:main Oct 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants