Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.8 deprecation warning and unsupported error #11166

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

amazimbe
Copy link
Contributor

What are you trying to accomplish?

Adds changes to set python 3.8 as deprecated and eventually unsupported. The deprecation warning and unsupported error are controlled by the following feature flags:

  • python_3_8_deprecation_warning
  • python_3_8_unsupported_error

Feature Flags PR: https://github.com/github/dependabot-api/pull/5763

This mirrors the approach used for Bundler v1, composer 1 etc allowing us to guide users towards migrating to python 3.13 while providing a controlled rollout.

How will you know you've accomplished your goal?

We will monitor logs and metrics to ensure:

  • Python 3.8 users see the deprecation warning when the feature flag is enabled.
  • Actions using python 3.8 are blocked when the unsupported error flag is enabled.
  • Tests have been added to validate the behaviour of both feature flags.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Dec 23, 2024
@amazimbe amazimbe marked this pull request as ready for review December 23, 2024 14:56
@amazimbe amazimbe requested a review from a team as a code owner December 23, 2024 14:56
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amazimbe amazimbe merged commit c0b00ef into main Dec 24, 2024
60 checks passed
@amazimbe amazimbe deleted the amazimbe/deprecate-python-3.8 branch December 24, 2024 14:38
@kbukum1
Copy link
Contributor

kbukum1 commented Dec 24, 2024

@amazimbe
There should be a follow up PR that will integrate the deprecation/unsupported into core that will send or add information for PR or alerts similar to how we do for package manager deprecation and unsupported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants