Fixes pip-compile file matcher for metric collection #11174
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazimbe
approved these changes
Dec 23, 2024
| @@ -337,7 +337,7 @@ def check_requirements(requirements) | |||
| end | |||
|
|
|||
| def pipcompile_in_file | |||
| requirement_files.any? { |f| f.end_with?(".in") } | |||
| requirement_files.any? { |f| f.name.end_with?(PipCompilePackageManager::MANIFEST_FILENAME) } | |||
There was a problem hiding this comment.
can we have a unit test covering this?
sachin-sandhu
force-pushed
the
ssandhu-fixes-pip-compile-detect
branch
from
fa441a0 to
5e9bcf7
Compare
sachin-sandhu
force-pushed
the
ssandhu-fixes-pip-compile-detect
branch
from
5e9bcf7 to
ec8b302
Compare
abdulapopoola
approved these changes
Dec 23, 2024
amazimbe
reviewed
Dec 24, 2024
| @@ -881,6 +881,18 @@ | |||
| ) | |||
| end | |||
| end | |||
|
|
|||
| it "returns the correct ecosystem and package manager set" do | |||
| parser.parse do |parser| | |||
There was a problem hiding this comment.
I don't think you need parser.parse at all. It can just be parser.ecosystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixed issue where we were not able to capture pip-compile package manager in metric collection.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist