Update Smoke Tests for NPM 8 Fallback and Lockfile Version 3 with NPM 9 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Oct 9, 2024
| version: 1.1.0 | ||
| directory: /npm/multi-dir/bar | ||
| updated-dependency-files: | ||
| - content: | | ||
| { | ||
| "name": "foo", | ||
| "version": "1.0.0", | ||
| "lockfileVersion": 3, | ||
| "lockfileVersion": 1, |
There was a problem hiding this comment.
No, normally it shouldn't. I am checking it. Also there are problems I am solving then will let you know.
There was a problem hiding this comment.
When running on 9, that is happening. I am trying to find out the reason.
| @@ -283,8 +241,8 @@ output: | |||
| type: file | |||
| pr-title: Bump the npm_and_yarn group across 2 directories with 3 updates | |||
| pr-body: | | |||
| Bumps the npm_and_yarn group with 2 updates in the /npm/multi-dir/foo directory: @dependabot/dummy-pkg-b and [left-pad](https://github.com/stevemao/left-pad). | |||
| Bumps the npm_and_yarn group with 2 updates in the /npm/multi-dir/bar directory: [left-pad](https://github.com/stevemao/left-pad) and @dependabot/dummy-pkg-a. | |||
| Bumps the npm_and_yarn group with 1 update in the /npm/multi-dir/foo directory: @dependabot/dummy-pkg-b. | |||
There was a problem hiding this comment.
is this a grouped updates bug?
xximwon
approved these changes
Dec 15, 2024
xximwon
approved these changes
Dec 15, 2024
xximwon
approved these changes
Dec 15, 2024
xximwon
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates our smoke tests to align with recent changes in the Dependabot Core project, specifically PR #10757, which sets npm 8 as the default and fallback version under the
npm_fallback_version_above_v6feature flag and assignslockfileVersion: 3to npm 9. These changes ensure our tests reflect the supported npm versions (7, 8, and 9), with npm 8 as the fallback and compatibility adjustments for lockfile versioning under npm 9.Key Updates
Why This is Important
Ensuring our smoke tests reflect npm 8 as the fallback and lockfile version 3 for npm 9 improves accuracy for projects without explicit npm versioning, providing reliable dependency resolution. These updates also validate the
npm_fallback_version_above_v6feature flag’s behavior, confirming that npm 8 is chosen as the fallback where applicable.Additional Notes