Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize GetBaseCurrencyPriceEndpoint to take multiple entries #708

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Generalize GetBaseCurrencyPriceEndpoint to take multiple entries #708

merged 1 commit into from
Dec 18, 2024

Conversation

diamondhands0
Copy link
Member

No description provided.

@diamondhands0 diamondhands0 requested a review from a team as a code owner December 17, 2024 23:30
lazynina
lazynina approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@lazynina lazynina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. If we hit performance issues, we'll address them then.

@lazynina lazynina merged commit 5790339 into main Dec 18, 2024
2 checks passed
@lazynina lazynina deleted the diamondhands/BULK-FETCH-BASE-CURRENCY-PRICES branch December 18, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazynina lazynina lazynina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diamondhands0 @lazynina