-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor searcher operations out of master side searchers #10024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## searcher-context-removal #10024 +/- ##
=============================================================
- Coverage 58.04% 39.86% -18.18%
=============================================================
Files 747 117 -630
Lines 103306 10048 -93258
Branches 3617 0 -3617
=============================================================
- Hits 59959 4006 -55953
+ Misses 43214 6042 -37172
+ Partials 133 0 -133
Flags with carried forward coverage won't be shown. Click here to find out more. |
d7ce21f
to
f987818
Compare
0914554
to
4bb779b
Compare
d2e6363
to
7212d0e
Compare
9e6084c
to
835fc8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a few questions but once we go over them i dont feel the need to review again.
dfd7d50
to
db8d4b0
Compare
Docsite preview being generated for this PR. |
2 similar comments
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending that last name change for closed/stopped
0c3aa59
to
1bf6561
Compare
Docsite preview being generated for this PR. |
0d28c2e
to
a0d898a
Compare
a0d898a
to
dabb122
Compare
2970bb2
into
searcher-context-removal
) Refactors searchers in master to no longer issue operation workloads to trials. This only functionally affects ASHA search algorithms, which are now preemption-based instead of promotion-based. - Removes all `SearcherOperation` APIs. - Removes the non-stopping variant of adaptive ASHA, deprecating the `stop_once` config option. - Removes and deprecates the `max_length` requirement for all experiments. - Introduces `time_metric` and `max_time` as new resource configuration options for ASHA searchers. - Reporting validation metrics now reports to the searcher (only affects ASHA searchers). - Preview HP Search was refactored to estimate training lengths based on ASHA rungs.
) Refactors searchers in master to no longer issue operation workloads to trials. This only functionally affects ASHA search algorithms, which are now preemption-based instead of promotion-based. - Removes all `SearcherOperation` APIs. - Removes the non-stopping variant of adaptive ASHA, deprecating the `stop_once` config option. - Removes and deprecates the `max_length` requirement for all experiments. - Introduces `time_metric` and `max_time` as new resource configuration options for ASHA searchers. - Reporting validation metrics now reports to the searcher (only affects ASHA searchers). - Preview HP Search was refactored to estimate training lengths based on ASHA rungs.
) Refactors searchers in master to no longer issue operation workloads to trials. This only functionally affects ASHA search algorithms, which are now preemption-based instead of promotion-based. - Removes all `SearcherOperation` APIs. - Removes the non-stopping variant of adaptive ASHA, deprecating the `stop_once` config option. - Removes and deprecates the `max_length` requirement for all experiments. - Introduces `time_metric` and `max_time` as new resource configuration options for ASHA searchers. - Reporting validation metrics now reports to the searcher (only affects ASHA searchers). - Preview HP Search was refactored to estimate training lengths based on ASHA rungs.
Ticket
Description
refactor of master-side searchers:
max_length
master-sideTODO:
Test Plan
Checklist
docs/release-notes/
See Release Note for details.