-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: un-nest CLIs, APIs, permissions and DB layer #10041
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shreya/createTable #10041 +/- ##
======================================================
- Coverage 59.16% 54.56% -4.60%
======================================================
Files 756 1266 +510
Lines 105153 158044 +52891
Branches 3632 3632
======================================================
+ Hits 62210 86238 +24028
- Misses 42809 71672 +28863
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @determined-ci, @jgongd on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla. After we approve your CLA, we will update the contributors list (private) and comment |
Docsite preview being generated for this PR. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @determined-ci, @jgongd on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla. After we approve your CLA, we will update the contributors list (private) and comment |
34be47a
to
5aedbcd
Compare
master/static/migrations/20241010174718_alter-user-session-add-access-token-info.tx.up.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid! Thanks for getting this knocked out so quickly! Maybe just do a quick rebase against the feature branch to clean up the extra migrations commits and this should be good to go!
# fmt: off | ||
|
||
args_description = [ | ||
cli.Cmd("to|ken", None, "manage access tokens", [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you added a shortened version of token here, adds a clearer polish to this new set of subcommands!
Ticket
DET-10462
DET-10465
Description
Test Plan
Checklist
docs/release-notes/
See Release Note for details.