Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: INFENG-942: Conditionally bypass build-react job checks #10145

Merged
merged 4 commits into from
Oct 28, 2024

Commits on Oct 28, 2024

  1. The release job is skipping the React build step because there are two

    jobs that attempt to skip the entire job if no changes are detected in
    specific directories. Previously, bumpversion made it so that, by dint
    of updating various files, the job would not be skipped. Now that we
    aren't using it, though, certain downstream jobs are failing because
    React wasn't built.
    
    To fix this, I've added a "force" variable to the build-react job, to
    allow conditionally bypassing the checks if indicated by the
    caller. This preserves existing behavior, to avoid potentially other
    unintended consequences of beginning to build React everywhere, but also
    to avoid running up CircleCI compute bills, as this much extra build
    time would probably have a material effect on spending.
    davidfluck-hpe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    38768af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58306b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc13223 View commit details
    Browse the repository at this point in the history
  4. Remove list.

    davidfluck-hpe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c0ea08c View commit details
    Browse the repository at this point in the history