Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: INFENG-883: remove unused docs version picker code #9964

Merged

Conversation

davidfluck-hpe
Copy link
Contributor

Ticket

INFENG-883

Description

This changeset deletes two docs-related scripts that are now unnecessary in light of the recent release process redesign. They're both involved in updating the version picker versions.json file, which we no longer need to modify statically.

Test Plan

Build Determined and verify that it completes successfully.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

release process that generates the version picker JSON file dynamically.

* Delete docs/insert-version-url.py.

* Delete tools/scripts/insert-dropdown-url.sh.
@cla-bot cla-bot bot added the cla-signed label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.90%. Comparing base (9c0bad9) to head (0158eb0).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           INFENG-382-release-redesign    #9964      +/-   ##
===============================================================
- Coverage                        58.51%   53.90%   -4.62%     
===============================================================
  Files                              762      734      -28     
  Lines                           104433   102597    -1836     
  Branches                          3504     3504              
===============================================================
- Hits                             61113    55305    -5808     
- Misses                           43174    47146    +3972     
  Partials                           146      146              
Flag Coverage Δ
backend 43.77% <ø> (ø)
harness 56.35% <ø> (-16.28%) ⬇️
web 53.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 155 files with indirect coverage changes

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Sep 20, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci requested a review from a team September 20, 2024 20:53
Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less is more

@davidfluck-hpe davidfluck-hpe merged commit 86599ec into INFENG-382-release-redesign Sep 20, 2024
77 of 95 checks passed
@davidfluck-hpe davidfluck-hpe deleted the INFENG-883-remove-unused-code branch September 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants