Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search as URL parameter #476

Draft
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

Malix-Labs
Copy link

@Malix-Labs Malix-Labs commented Oct 1, 2024

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

Description

Enhance search as URL parameter
Also making it DRY, so it reduces the number of lines overall

@Malix-Labs Malix-Labs requested a review from a team as a code owner October 1, 2024 09:28
@Malix-Labs Malix-Labs marked this pull request as draft October 1, 2024 09:32
@Malix-Labs
Copy link
Author

Tables are broken on 2 out of 3 pages, reverting to draft

It works perfectly for collection though : https://malix-labs.github.io/devcontainers.github.io/collections?search=test

@Malix-Labs
Copy link
Author

Malix-Labs commented Oct 1, 2024

I need help by someone knowing the codebase, I don't seem to succeed understanding how it would be supposed to work and fetch data

Again, collections work with perfect UX, but not features or template (see https://malix-labs.github.io/devcontainers.github.io/collections?search=test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search as URL parameter
1 participant